This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): re-position tooltip after draw #944 #1074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a manual inspection, to check if everything displays correctly in the following browsers all on Ubuntu 13.04 accept IE that is on a Win7: Chrome 30.0 - Passes |
|
Woops, this PR was closed by accident (!). Reviewing it just now as it seems to be a proper fix for #944 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved positioning of tooltip to a function.
Made show function return the positioning function as a callback.
Made call to callback after show to re-position tooltip after draw to resolve tooltip content wrapping/centering issues. (#944)