use pre-link function in tabset instead of post-link #1171
Conversation
…ler's attributes used in tabsetTitles post-link are surely initialized
|
I'm testing this patch and looks like it works without problems. Cheers! |
|
It works for me too |
|
@daa I would love to merge this but, as noted, it doesn't work on the current AngularJS stable :-( |
|
@pkozlowski-opensource what about creating branch ready for 1.2 release? |
|
ok. I think it can wait until angular-1.2 stable release. |
|
Hi @pkozlowski-opensource . I have checked the fix made by @daa and using the stable release of Angular JS 1.2, now the error I had in my application (Issue #783) is gone (which is very good). The question I have to you is, is it now a good time to merge the change to a new version of the angular-ui bootstrap? Thanks ! |
|
+1 I am also waiting for this to be merged. |
|
+1 |
1 similar comment
|
+1 |
|
We've just fixed it in master by removing ability to set the direction for tabs: |
Now controller's attributes $scope and $transcludeFn used in tabsetTitles post-link are surely initialized.
I had issue similar to #783 using tabs inside of ng-if directive - tabsetTitles postlink function ran before tabset link function, so i moved tabset link to pre-link and with angular-1.2.0-rc.3 it worked. But it can't work with earlier angular versions because of angular/angular.js#3927 - before this commit pre-link functions received undefined instead of directive controller.
plunker with problem:
http://plnkr.co/edit/MoRweJ?p=preview
plunker with fix:
http://plnkr.co/edit/D3n45R?p=preview