This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): leaking watchers on toggling (WIP) #1601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to use a new child scope every time as watchers leak into scope. If linked DOM is removed, watchers from directives in that DOM aren't removed. Regression from angular-ui#1455
ghost
assigned 
|
@chrisirhc this PR is still marked as WIP, are you planning to add / change anything in here? |
|
@pkozlowski-opensource , I think I marked this as WIP because #1600 would supersede this and wasn't sure whether to close this as-is or keep it for maintenance of older versions. |
|
Sounds great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to use a new child scope every time as watchers leak into
scope. If linked DOM is removed, watchers from directives in that DOM
aren't removed.
Regression from #1455
This seems like a tough one to add a test for besides counting the number of total watchers. Perhaps that's a good strategy. I'll keep that in mind and possibly add that tomorrow. Heading to sleep.