This repository has been archived by the owner on May 29, 2019. It is now read-only.
chore(rating): remove redundant validation and add unit tests #3464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Working Plunker with the changes (line 3122 of ui-bootstrap.js shows the validation removed):
http://plnkr.co/edit/68xfeULwQhaHeq3W5mD1?p=preview
Plunker with the current version of the rating directive:
http://plnkr.co/edit/XBR4r3OuDSknWwgvpjPE?p=preview
Both behave the same (with and without the validation).