Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox number edit #6953

Closed
waclaw66 opened this issue Mar 28, 2019 · 2 comments
Closed

Firefox number edit #6953

waclaw66 opened this issue Mar 28, 2019 · 2 comments

Comments

@waclaw66
Copy link

waclaw66 commented Mar 28, 2019

Hello everybody.

I have troubles with following example running in Firefox (66, 67, 68, clean profile)...
http://ui-grid.info/docs/#!/tutorial/Tutorial:%20201%20Edit%20Feature

When I click to the Age cell the input is shown normally on the ui-grid.info page, but when I open this example on the Plunker page, Age cell cannot be edited normally by single doubleclick. You have to realy try to click multiple times and sometimes it succeeds or press F2 and hold it for a while. It also happens on my project's page, so there is some connection.
Other cell types work ok, only number type has this problem. I suspect, that the input is shown, but immediately exited, because I see "Last Cell Edited" row changing.
No problems occur within Chrome, Edge or IE.

Does it happen to you too?

Thanks.

@waclaw66
Copy link
Author

I tried to debug the code which handles editing the cell. The cell is definetelly edited, but then the edit mode is cancelled. I do not understand the reason, there is lot of code with timeouts which is not clear to me. The input is cancelled after hiting this line...

obrazek

Maybe helps also screen with stack few steps before...
obrazek

AngularJS v1.7.8
ui-grid - v4.7.1

Thanks for help!

@waclaw66
Copy link
Author

I just found the problem. When I added the following line (ui-grid.js:14737)...
obrazek
the problem disappeared.

Could you please apply this fix?

Thanks!

@mportuga mportuga self-assigned this May 3, 2019
mportuga pushed a commit that referenced this issue Sep 26, 2020
Adding line provided by waclaw66 to set focus outside of timeout for
firefox number edit

Closes: #6953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants