Skip to content

Commit

Permalink
fix(uiView): Refactoring uiView directive to copy ngView logic
Browse files Browse the repository at this point in the history
 - Changed the structure of the uiView directive to work more like ngView.
 - Updated tests to work with new structure.
 - Updated tests so that all assertions actually run through AngularJS 1.0.8.
 - Added in extensive test for ngIf fix.
 - Added in ability for uiView to work with ngIf, ngRepeat, and ngClass.
 - Updated base AngularJS version to 1.2.14 to test $animate callbacks in 1.2.*
 - Fixes controllerAs so that it will work within a view declaration.

Closes #857, #552
  • Loading branch information
Cody Lundquist committed Mar 6, 2014
1 parent cb1c9cf commit 548fab6
Show file tree
Hide file tree
Showing 13 changed files with 6,900 additions and 5,070 deletions.
2 changes: 1 addition & 1 deletion config/karma.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = function (karma) {
basePath: '..',

// list of files / patterns to load in the browser
files: [].concat(files.angular('1.2.4'), files.testUtils, files.src, files.test),
files: [].concat(files.angular('1.2.14'), files.testUtils, files.src, files.test),

// level of logging
// possible values: LOG_DISABLE || LOG_ERROR || LOG_WARN || LOG_INFO || LOG_DEBUG
Expand Down
4 changes: 2 additions & 2 deletions files.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ routerFiles = {
return [
'lib/angular-' + version + '/angular.js',
'lib/angular-' + version + '/angular-mocks.js'
].concat(version === '1.2.4' ? ['lib/angular-' + version + '/angular-animate.js'] : []);
].concat(version === '1.2.14' ? ['lib/angular-' + version + '/angular-animate.js'] : []);
}
};

if (exports) {
exports.files = routerFiles;
}
}
Loading

0 comments on commit 548fab6

Please sign in to comment.