Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn to install beta version have incompatible problem #3086

Closed
zack9433 opened this issue Oct 13, 2016 · 7 comments
Closed

Use yarn to install beta version have incompatible problem #3086

zack9433 opened this issue Oct 13, 2016 · 7 comments
Milestone

Comments

@zack9433
Copy link

zack9433 commented Oct 13, 2016

My yarn version is v0.15.1 and node version is v4.x

There is an error occur

error angular-ui-router@1.0.0-beta.1: The engine "node" is incompatible with this module. Expected version ">4".
error Found incompatible module

I thinks yarn will look into engines version in package.json file.

@christopherthielen
Copy link
Contributor

Thanks, I'll take a look

@christopherthielen christopherthielen added this to the 1.0.0-final milestone Oct 13, 2016
@samithaf
Copy link

Looks like NPM also catches this one but just log it as a Warn rather than an error.

10:00:39.981 npm WARN engine angular-ui-router@1.0.0-alpha.5: wanted: {"node":">4"} (current: {"node":"4.4.7","npm":"2.15.8"})

@Luddinus
Copy link

+1

@hulkish
Copy link

hulkish commented Oct 25, 2016

Is there amy chance we can get this fix published to npm? id like to start using yarn for my project and this seems to.be blocking at the moment

@Luddinus
Copy link

This is the message I'm getting: (windows 7), if it helps

"error angular-ui-router@1.0.0-beta.3: The engine "node" is incompatible with this module. Expected version ">4".
error Found incompatible module"

@jonrimmer
Copy link

As a workaround, Yarn has an "--ignore-engines" CLI flag that should skip the check. You'll need to be running Yarn v0.16.

@christopherthielen
Copy link
Contributor

I'd like to get beta.4 out ASAP, but there are a few things blocking it at the moment:

Split mono-repo

core, ng1 and ng2 are now split out as three separate repositories. This housekeeping is mostly done. I think the last things to to address are:

  • how to do the bower publishing for ng1.
  • commits to core should cause CI to fetch the other repos and run the unit tests (for ng1, ng2, and react) -- this doesn't have to be complete before a beta.4 release

ng1/ng2 docs split

I've split up the generated API documentation into ng1 and ng2. These need to be published to the ui-router.github.io site in a way that doesn't break most of the existing docs links.

Instead of /docs/latest and /docs/1.0.0-beta.3 I think we'll do /ng1/docs/latest and /ng2/docs/1.0.0-beta.4

When I moved docs earlier I used redirect files. This will probably work for this scenario too.

ng1 docs simplification

I've simplified the docs for ng2, hiding most of the internal apis.
The same should be done for ng1 docs.

This isn't necessarily a blocker for beta.4 but would be nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants