feat(UrlMatcher): Add param only type names #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateabele
added a commit
that referenced
this pull request
Oct 6, 2015
feat(UrlMatcher): Add param only type names
| @@ -917,7 +917,8 @@ function $UrlMatcherFactory() { | |||
| } | |||
|
|
|||
| function getType(config, urlType, location) { | |||
| if (config.type && urlType) throw new Error("Param '"+id+"' has two type configurations."); | |||
| if (config.type && urlType.name !== 'string') throw new Error("Param '"+id+"' has two type configurations."); | |||
| if (config.type && urlType.name === 'string' && $types[config.type]) return $types[config.type]; | |||
There was a problem hiding this comment.
Since urlType is optional, this code will break on url-less parameters. I liked the direction of your previous logic better, where it checks if config.type is a string.
angular.isString is a handy utility for checking if something is a string or not
|
I see why you made the changes you did. There are some interactions with the url param type. I'm going to take this and massage it a bit. Thanks for your efforts! |
|
updated PR: #2296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #983 (comment)