Prepend the baseHref to $state.href() generated urls if it exists.

[tgecho]

I have an angular app that is served from a subdirectory. I have a <base href="/app/"> tag, however the urls generated by the ui-sref directive and $state.href() do not reflect this. The ui-sref links themselves will still work if left clicked, however middle clicking to open in a new tab does not work since the url is missing the contents of the base href.

I think this pretty much covers things the various scenarios...

[nateabele]

It'd be better if the value was pre-calculated and cached outside the function.

[nateabele]

Looks like some other stuff needs to be mocked properly in order for the tests to pass. Please squash your commits when done. Thanks.

[tgecho]

That's strange... the tests passed on my end. Oh well, I'll figure it out. Thanks!

[mfield]

Someone noticed me futzing with baseHref in a code review and wanted to know what's up. Instead of answering him, I thought I'd chime in here.

If you put the test in its own suite, you can set up the mock in a beforeEach to get it set up before the baseHref gets cached in $stateProvider.$get. The test passes locally after that change (but didn't with the original branch -- not sure why it did for @tgecho).

Check it out at https://github.com/mfield/ui-router/compare/basehref or I can make another PR if that's better.

[anton000]

+1 this should solve #638

[Guuz]

👍

[Guuz]

Thanks for this!
Any estimate on when there will be a new release? Else I will have to cherry pick this fix and I would rather not do that.

[samypr100]

Is there any option I can turn automatic prefixing of the base URL off? or make it configurable ui-sref-option like "prefixBase: false"? Thanks!