fix(uiView): Do NOT autoscroll when autoscroll attr is missing #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone want to review before I merge this? |
|
Hey, sorry I didn't see this before I merged the other one. If you wanna update and rebase, I'll push the big green button for ya (or feel free to do it yourself). Ping me if you need help squashing commits. |
|
👍 - I've been putting BTW, when you rebase, you are going to be some mega conflicts. That code was moved to the |
| elem.append($compile('<div><ui-view></ui-view></div>')(scope)); | ||
| $state.transitionTo(aState); | ||
| $q.flush(); | ||
| if ($animate) $animate.flush(); | ||
| expect($uiViewScroll).toHaveBeenCalledWith(elem.find('span').parent()); | ||
| expect($uiViewScroll).not.toHaveBeenCalledWith(elem.find('span').parent()); |
There was a problem hiding this comment.
You could just do expect($uiViewScroll).not.toHaveBeenCalled(); - no need to have the With(elem...) suffix.
Breaking Change: If you had ui-views that you wanted to autoscroll to on state change, you may now need to explicitly add `autoscroll="true"`. Fixes #807
timkindberg
added a commit
that referenced
this pull request
Mar 7, 2014
fix(uiView): Do NOT autoscroll when autoscroll attr is missing
tlvince
added a commit
to tlvince/LMIS-Chrome
that referenced
this pull request
Apr 1, 2014
tlvince
added a commit
to tlvince/LMIS-Chrome
that referenced
this pull request
Apr 2, 2014
tlvince
added a commit
to tlvince/LMIS-Chrome
that referenced
this pull request
Apr 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(uiView): Do NOT autoscroll when autoscroll attr is missing
Breaking Change: If you had ui-views that you wanted to autoscroll to on state change, you may now need to explicitly add
autoscroll="true". Fixes #807