Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Commit

Permalink
fix(templates): autocomplete off to false
Browse files Browse the repository at this point in the history
  • Loading branch information
dimirc committed Sep 28, 2015
1 parent bc3de20 commit a3e2e95
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/bootstrap/select-multiple.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div>
<div class="ui-select-match"></div>
<input type="text"
autocomplete="off"
autocomplete="false"
autocorrect="off"
autocapitalize="off"
spellcheck="false"
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/select.tpl.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="ui-select-container ui-select-bootstrap dropdown" ng-class="{open: $select.open}">
<div class="ui-select-match"></div>
<input type="text" autocomplete="off" tabindex="-1"
<input type="text" autocomplete="false" tabindex="-1"
aria-expanded="true"
aria-label="{{ $select.baseTitle }}"
aria-owns="ui-select-choices-{{ $select.generatedId }}"
Expand Down
2 changes: 1 addition & 1 deletion src/select2/select-multiple.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<li class="select2-search-field">
<input
type="text"
autocomplete="off"
autocomplete="false"
autocorrect="off"
autocapitalize="off"
spellcheck="false"
Expand Down
2 changes: 1 addition & 1 deletion src/select2/select.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<div class="ui-select-dropdown select2-drop select2-with-searchbox select2-drop-active"
ng-class="{'select2-display-none': !$select.open}">
<div class="select2-search" ng-show="$select.searchEnabled">
<input type="text" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"
<input type="text" autocomplete="false" autocorrect="false" autocapitalize="off" spellcheck="false"
role="combobox"
aria-expanded="true"
aria-owns="ui-select-choices-{{ $select.generatedId }}"
Expand Down
2 changes: 1 addition & 1 deletion src/selectize/select.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ng-class="{'focus': $select.open, 'disabled': $select.disabled, 'selectize-focus' : $select.focus}"
ng-click="$select.activate()">
<div class="ui-select-match"></div>
<input type="text" autocomplete="off" tabindex="-1"
<input type="text" autocomplete="false" tabindex="-1"
class="ui-select-search ui-select-toggle"
ng-click="$select.toggle($event)"
placeholder="{{$select.placeholder}}"
Expand Down

2 comments on commit a3e2e95

@xingd
Copy link

@xingd xingd commented on a3e2e95 Oct 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autocomplete="false“ not working on Edge, "off" works

@T89L
Copy link

@T89L T89L commented on a3e2e95 Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this was done because chrome was not respecting autocomplete="off", however this has been fixed recently (at least on desktop). See below:

https://codereview.chromium.org/1473733008

Please sign in to comment.