Failing tests with Angular 1.6 #1877
Comments
Angular 1.6 alters the way uncaught promises are handled - errors cause promise rejection rather than outright exceptions to be thrown. Update existing exception tests to use the exceptionHandler service instead of `.throws()` Closes angular-ui#1877
Angular 1.6 alters the way uncaught promises are handled - errors cause promise rejection rather than outright exceptions to be thrown. Update existing exception tests to use the exceptionHandler service instead of `.throws()` Closes #1877
|
Hi @pete-otaqui , this PR was only to support angular version 1.5 and 1.6 right? I see a lot of problems with new PR's and it looks like this change has to do with it. |
|
Hi @Jefiozie It was only to support angular 1.6, yes, since it gobbles up errors, and requires you to use angular's own exceptionHandler rather than ... you know ... Javascript's own means for doing that. What specific problems are you referring to? |
|
Hi @pete-otaqui , Thanks for the quick reply. Since the merge of your PR I see that all "new" PR's have build errors. I removed your adjustments and as it looks the problems are gone. (see: #1917 ) |
4 tests fail with Angular 1.6 (the latest version that is installed by default since it's release).
Specifically related to this breaking change between 1.5 and 1.6:
angular/angular.js@e13eeab
Exceptions inside promises are now handled as rejections.
The text was updated successfully, but these errors were encountered: