This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the following:
#850
and
#914
The fix adds a custom validator to multiple selects that enables the
required
tag. Custom validators are not "my" own customized way of doing things, they are the official angular way of writing validators as outlined in the Custom Validators section here https://docs.angularjs.org/guide/formsThe problem was that required checks the ngModel's viewModel, which when empty on a ui-select-multiple is an empty array...which is technically not empty. Now it checks properly without interfering with the standard required validator.
Also fixed a test bug where $item.name wasn't being used in the multiple example.