This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Use ng-attr for placeholder #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added dist files to my repo so I can use it while I wait for this to be reviewed. |
|
Interesting - I stand corrected and deleted my comments. This just needs the dist changes removed and rebasing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder attr throws an error in IE10 and 11 (and maybe earlier versions?) and an easy solution is to use the ng-attr prefix. More info here: angular/angular.js#5025
I visually validated that it works fine and ran gulp and all tests passed. I didn't include the updated dist files here because I didn't know what your process was but can happily do whatever you need.