Skip to content

Commit

Permalink
fix: change inline-source-map to source-map for dev and common, prod …
Browse files Browse the repository at this point in the history
…already supports (#1659)
  • Loading branch information
TheLarkInn authored and filipesilva committed Aug 12, 2016
1 parent 10dd465 commit e0454e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion addon/ng2/models/webpack-build-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { CliConfig } from './config';

export function getWebpackCommonConfig(projectRoot: string, sourceDir: string) {
return {
devtool: 'inline-source-map',
devtool: 'source-map',
resolve: {
extensions: ['', '.ts', '.js'],
root: path.resolve(projectRoot, `./${sourceDir}`)
Expand Down
2 changes: 1 addition & 1 deletion addon/ng2/models/webpack-build-development.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const path = require('path')
export const getWebpackDevConfigPartial = function(projectRoot: string, sourceDir: string) {
return {
debug: true,
devtool: 'cheap-module-source-map',
devtool: 'source-map',

This comment has been minimized.

Copy link
@mmrath

mmrath Aug 15, 2016

Contributor

@TheLarkInn @filipesilva This does not appear to be working. I am using master version of CLI and ng server fails for a very basic app with material. I have changed from 'source-map' to 'cheap-module-source-map' and then ng serve works. Because I am not sure if you already know it, and master is not yet released, I am reluctant to raise a defect. Please let me know if you need a sample to reproduce.

This comment has been minimized.

Copy link
@clydin

clydin Aug 16, 2016

Member

I can confirm the issue. Both ng serve and ng build crash when targeting dev. However, this commit on its own appears to work. It seems to be caused by the combination with this commit: 67098e0.

This comment has been minimized.

Copy link
@filipesilva

filipesilva Aug 22, 2016

Contributor

@TheLarkInn can you have a look?

This comment has been minimized.

Copy link
@TheLarkInn

TheLarkInn Aug 22, 2016

Author Member

That commit @clydin referenced has actually 'reverted' to some extent. Also sourcemaps should be working as of #1659.

This comment has been minimized.

Copy link
@TheLarkInn

TheLarkInn Aug 22, 2016

Author Member

22a6b59 is the commit in question that @clydin was concerned about.

output: {
path: path.resolve(projectRoot, './dist'),
filename: '[name].bundle.js',
Expand Down

0 comments on commit e0454e3

Please sign in to comment.