-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change inline-source-map to source-map for dev and common builds. #1659
fix: change inline-source-map to source-map for dev and common builds. #1659
Conversation
LGTM |
Awesome 👍 |
Also fixes #1490 |
I can confirm that it is fixed, but the build times are now twice as slow at my side :) But still workable. 2 seconds for each change as build time. |
It still does not work I think. simple ng new project is fine but once I add material2 ng serve throws error. If I revert the source-map change then it works. More details at #1490 (comment) |
I am getting this debug/mapping mal-config problem too. The debugging was working fine for a while, but after my app got to a critical mass (like around 20 components) it has started to get wonkie: breakpoints won't hit, or impossible to set breakpoint (off by x number of lines) angular-cli: 1.0.0-beta.18 NPM: 3.10.8 |
@nukuuk in beta.18 we have a sourcemap issue, but it will be fixed in beta.19 |
@filipesilva installed beta.19, and am still having problems setting breakpoints :( |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #1519 where either a chrome or webpack issue is causing inline-source-map and cheap-module-source-map to display inaccurately for development and production mode (in some cases).