Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I18n] New locale codes not supported by angular.json #17032

Closed
floreks opened this issue Feb 20, 2020 · 2 comments · Fixed by #17033
Closed

[I18n] New locale codes not supported by angular.json #17032

floreks opened this issue Feb 20, 2020 · 2 comments · Fixed by #17033
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone

Comments

@floreks
Copy link

floreks commented Feb 20, 2020

According to I18n documentation, language code such as zh-Hant-HK should be supported. Documentation also points you to the list of all supported locales on the angular repo.

It seems however that those codes are blocked by the regular expression defined in the schema.

"locales": {
"type": "object",
"additionalProperties": false,
"patternProperties": {
"^[a-z]{2}(-[a-zA-Z]{2,})?$": {

Zrzut ekranu z 2020-02-20 16-27-55

@clydin
Copy link
Member

clydin commented Feb 20, 2020

Thank you for pointing this out. It was actually updated above that line but this instance appears to have been missed. A fix will be available in the next patch release.

@ngbot ngbot bot added this to the needsTriage milestone Feb 20, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Feb 20, 2020
clydin added a commit to clydin/angular-cli that referenced this issue Feb 20, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Feb 20, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Feb 20, 2020
@alan-agius4 alan-agius4 added the freq1: low Only reported by a handful of users who observe it rarely label Feb 20, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Feb 20, 2020
dgp1130 pushed a commit that referenced this issue Feb 24, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
3 participants