Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command completion is invalid with 1.0.0-beta.11-webpack.8 #1889

Closed
goorockey opened this issue Aug 30, 2016 · 7 comments
Closed

command completion is invalid with 1.0.0-beta.11-webpack.8 #1889

goorockey opened this issue Aug 30, 2016 · 7 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@goorockey
Copy link
Contributor

goorockey commented Aug 30, 2016

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

    Ubuntu latest 16.04 LTS

  2. Versions. Please run ng --version. If there's nothing outputted, please run
    in a Terminal: node --version and paste the result here:

    angular-cli: local (v1.0.0-beta.11-webpack.8, branch: master)
    node: 6.5.0
    os: linux x64

  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.

    git clone https://github.com/angular/angular-cli.git
    cd angular-cli
    npm link
    ng completion

  4. The log given by the failure. Normally this include a stack trace and some
    more information.

    $ ng completion
    The specified command completion is invalid. For available options, see ng help.

  5. Mention any other details that might be useful.

    After looking around the source code in addon/ng2/index.js, I think the problem is that command/completion has not default exports.
    It should work after refactoring completion.js to completion.ts and having default export according to other commands.


Thanks! We'll be in touch soon.

@goorockey
Copy link
Contributor Author

BTW, make-thie-awesome is also invalid with the same reason.

goorockey added a commit to goorockey/angular-cli that referenced this issue Aug 30, 2016
@catull
Copy link
Contributor

catull commented Aug 30, 2016

make-this-awesome explicitly only works in a project directory generated by ng new.
The behaviour you describe manifests if you execute the command outside of such a directory.

Carefully read the warning it gives you:

You have to be inside an angular-cli project in order to use the make-this-awesome command.

@goorockey
Copy link
Contributor Author

@catull make-this-awesome doesn't work in project directory with the lastest version 1.0.0-beta.11-webpack.8.
It's because of commit 8be7096, which does not published to npm registry.

@catull
Copy link
Contributor

catull commented Aug 30, 2016

@goorockey Sorry about that, your issue title does not reflect you tried it with that constellation.
Neither did you state it up until now.

goorockey added a commit to goorockey/angular-cli that referenced this issue Aug 30, 2016
@goorockey goorockey changed the title command completion is invalid command completion is invalid with 1.0.0-beta.11-webpack.8 Aug 30, 2016
@goorockey
Copy link
Contributor Author

@catull My fault and the title is updated. 😄

@catull
Copy link
Contributor

catull commented Aug 30, 2016

The project has not been building for a while.
The reason is in my opinion due to a broken '@angular/tsc-wrapped' dependency.
Currently, that module's version 0.2.2 barfs up, see issue #1853.

If you locally replace node_modules/@angular/tsc-wrapped with a more recent release from https://github.com/angular/tsc-wrapped-builds/releases, then the project builds again.

@filipesilva filipesilva added type: bug/fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Sep 20, 2016
goorockey added a commit to goorockey/angular-cli that referenced this issue Sep 21, 2016
goorockey added a commit to goorockey/angular-cli that referenced this issue Sep 21, 2016
JJayet pushed a commit to JJayet/angular-cli that referenced this issue Oct 14, 2016
texel pushed a commit to splice/angular-cli that referenced this issue Nov 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants