Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/styles.scss compression #2578

Closed
MurhafSousli opened this issue Oct 7, 2016 · 6 comments
Closed

src/styles.scss compression #2578

MurhafSousli opened this issue Oct 7, 2016 · 6 comments
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@MurhafSousli
Copy link

Hi, I put all my components styles in src/styles.scss where I import other styles in it

@import 'style/vendors/_base';
@import 'style/core/_base';
@import 'style/modules/_base';

I do this to gain access to variables and mixins, but it appears that the CLI doesn't compress it before adding it to the head, is this intended or will it be fixed in the future?

@filipesilva
Copy link
Contributor

Hm, can you elaborate on what you mean by this bit?

the CLI doesn't compress it before adding it to the head

@filipesilva filipesilva added the needs: more info Reporter must clarify the issue label Oct 10, 2016
@MurhafSousli
Copy link
Author

MurhafSousli commented Oct 10, 2016

@filipesilva I mean the file src/style.scss doesn't get minified, all the styles I use and import are produced without compression
capture

@filipesilva
Copy link
Contributor

Got it. Will investigate.

@filipesilva filipesilva added needs: investigation Requires some digging to determine if action is needed type: bug/fix command: build P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs: more info Reporter must clarify the issue labels Oct 10, 2016
@filipesilva
Copy link
Contributor

Partially solved by #2593

@grizzm0
Copy link
Contributor

grizzm0 commented Oct 17, 2016

The CSS is minified. See the output style.js in your build dir.

What you're seeing in the head is the CSS from the JS file appended to head by the webpack plugin style-loader. This will be changed in #2646 as "outside of app" styles will compiled to a .css file instead of .js.

@filipesilva Can be closed.

@hansl hansl modified the milestone: RC1 Nov 11, 2016
@Brocco Brocco closed this as completed Jan 22, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

5 participants