feat(build): added postcss-discard-comments #2593
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is something that will be accepted or if we should wait for #1656.
I've got a single
@import "~material-design-lite/src/material-design-lite";
in my./src/style.scss
which results in 31 copies of each comment used in~material-design-lite/src/variables
aswell as a lot of other comments.Simply removing all CSS comments makes a huge difference in final bundle size as seen below.
Before
After