Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds #12824

Merged
merged 5 commits into from
Nov 1, 2018
Merged

Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds #12824

merged 5 commits into from
Nov 1, 2018

Commits on Nov 1, 2018

  1. fix(@schematics/angular): update karma version

    @filipesilva
    filipesilva committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    27d9882 View commit details
    Browse the repository at this point in the history

  2. feat(@angular-devkit/build-angular): stop karma gracefully 

    Followup to karma-runner/karma#3153
    @filipesilva
    filipesilva committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    7dd7955 View commit details
    Browse the repository at this point in the history

  3. feat(@ngtools/webpack): only do type checking on forked type checker 

    Syntactic errors were only being reported in the type checker when it was running. This caused rebuilds to finish successfully if they had syntactic errors, which could lead to very weird behaviour on rebuilds.
    @filipesilva
    filipesilva committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    6803b91 View commit details
    Browse the repository at this point in the history

  4. test(@angular-devkit/build-angular): remove unneeded flag from test

    @filipesilva
    filipesilva committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    1774624 View commit details
    Browse the repository at this point in the history

  5. test(@angular-devkit/build-angular): test karma on watch mode

    @filipesilva
    filipesilva committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    1453b9d View commit details
    Browse the repository at this point in the history