Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): don't elide imports for type references that … #16822

Merged
merged 1 commit into from
Feb 4, 2020
Merged

fix(@ngtools/webpack): don't elide imports for type references that … #16822

merged 1 commit into from
Feb 4, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 3, 2020

…are needed for decorator metadata

When emitDecoratorMetadata is set to true we don't elide type references imports that are used for decorated nodes.

Fixes #16808

Jira: TOOL-1308

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 4, 2020
@alan-agius4 alan-agius4 marked this pull request as ready for review February 4, 2020 08:15
…re needed for decorator metadata

When `emitDecoratorMetadata` is set to true we don't elide type references imports that are used for decorated nodes.

Fixes #16808
@alan-agius4 alan-agius4 added this to the v9-blockers milestone Feb 4, 2020
@mgechev mgechev merged commit 5376a8b into angular:master Feb 4, 2020
@alan-agius4 alan-agius4 deleted the decorator-metadata branch February 5, 2020 05:55
@filipesilva filipesilva mentioned this pull request Feb 14, 2020
13 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production build breaks in rc.11 & 12
5 participants