Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(@angular-devkit/build-angular): pin node-sass to version 4 #19276

Closed
wants to merge 1 commit into from
Closed

test(@angular-devkit/build-angular): pin node-sass to version 4 #19276

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Collaborator

The current version of sass-loader doesn't support node-sass version 5.

webpack-contrib/sass-loader#898

The curent version of sass-loader doesn't support node-sass version 5.

webpack-contrib/sass-loader#898
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@alan-agius4 alan-agius4 added target: lts This PR is targeting a version currently in long-term support target: patch This PR is targeted for the next patch release labels Nov 2, 2020
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Nov 2, 2020

Caretaker: please merge this in all LTS branches.

@alan-agius4 alan-agius4 changed the title @alan-agius4 test(@angular-devkit/build-angular): pin node-sass to version 4 test(@angular-devkit/build-angular): pin node-sass to version 4 Nov 2, 2020
@alan-agius4 alan-agius4 requested a review from clydin November 2, 2020 08:37
@alan-agius4 alan-agius4 removed the target: patch This PR is targeted for the next patch release label Nov 2, 2020
@alan-agius4 alan-agius4 closed this Nov 2, 2020
@alan-agius4 alan-agius4 deleted the node-sass-version branch November 2, 2020 12:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant