Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(@angular-devkit/build-angular): pin node-sass to version 4 #19280

Merged
merged 1 commit into from
Nov 2, 2020
Merged

test(@angular-devkit/build-angular): pin node-sass to version 4 #19280

merged 1 commit into from
Nov 2, 2020

Conversation

alan-agius4
Copy link
Collaborator

The curent version of sass-loader doesn't support node-sass version 5.

webpack-contrib/sass-loader#898
(cherry picked from commit 6717d18)
(cherry picked from commit c4e8c71)

The curent version of sass-loader doesn't support node-sass version 5.

webpack-contrib/sass-loader#898
(cherry picked from commit 6717d18)
(cherry picked from commit c4e8c71)
@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label Nov 2, 2020
@alan-agius4 alan-agius4 requested a review from clydin November 2, 2020 12:01
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2020
@alan-agius4
Copy link
Collaborator Author

@filipesilva, please merge as ci cannot go green because of missing step.

@filipesilva filipesilva merged commit 43abd0a into angular:9.1.x Nov 2, 2020
@alan-agius4 alan-agius4 deleted the node-sass-lts-9 branch November 2, 2020 20:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants