refactor(@angular/build): Auto-CSP support as an index file transformation. #28639
Conversation
angular-robot
bot
added
detected: feature
There was a problem hiding this comment.
Thanks for putting this together! Very excited to see this feature land.
I left a bunch of readability / refactoring suggestions, but none of them are really critical and what you have is pretty reasonable so feel free to decline any which aren't worth applying.
For the commit message, we should use refactor here since it doesn't actually expose any functionality yet. When you get to the "keystone" commit which exposes the relevant option for end users, that's where you would put feat to be included in the changelog.
aaronshim
changed the title
| }, | ||
| ): string { | ||
| hashes = hashes || []; | ||
| let strictCspTemplate = { |
There was a problem hiding this comment.
Yeah, I mean something like:
const strictCspTemplate = new Map<string, string[]>(Object.entries({
'script-src': [`'strict-dynamic'`, ...hashes],
// ...
}));
// Update / assign like:
strictCspTemplate.set('require-trusted-types-for', ['script']);
// Consume at the end:
return Array.from(strictCspTemplate.entries()).map(([directive, value]) => `${directive} ${values.join(' ')};`)
.join('');Since all the keys are static string literals, it's really not that important so feel free to ignore. Just a thing I commonly recommend for any dynamic key usage since that commonly leads to prototype pollution vulnerabilities.
|
FYI: For a review, the commits you have are probably fine, but once this is approved and ready to submit, you'll need to squash/amend them to match the commit message conventions so we can merge it. Just a heads up. |
For sure! I realized that the GitHub code review interface was hiding comments as "outdated" and such when I amended and force pushed on the same commit, so I decided to stop doing that until we are ready to merge! |
aaronshim
force-pushed
the
main
branch
3 times, most recently
from
a4b0928 to
4168106
Compare
…ation. Auto-CSP is a feature to rewrite the `<script>` tags in a index.html file to either hash their contents or rewrite them as a dynamic loader script that can be hashed. These hashes will be placed in a CSP inside a `<meta>` tag inside the `<head>` of the document to ensure that the scripts running on the page are those known during the compile-time of the client-side rendered application.
Following up on the logic provided in angular#28639, we want to offer an opt-in option in angular.json to enable the auto-CSP transformation.
Following up on the logic provided in angular#28639, we want to offer an opt-in option in angular.json to enable the auto-CSP transformation. For now, builds for `ng serve` will have Auto-CSP disabled.
Following up on the logic provided in angular#28639, we want to offer an opt-in option in angular.json to enable the auto-CSP transformation. For now, builds for `ng serve` will have Auto-CSP disabled.
Following up on the logic provided in #28639, we want to offer an opt-in option in angular.json to enable the auto-CSP transformation. For now, builds for `ng serve` will have Auto-CSP disabled.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Auto-CSP is a feature to rewrite the
<script>tags in a index.html file to either hash their contents or rewrite them as a dynamic loader script that can be hashed. These hashes will be placed in a CSP inside a<meta>tag inside the<head>of the document to ensure that the scripts running on the page are those known during the compile-time of the client-side rendered application.This is an application of the recommended Strict CSP approach that is also recommended by the OWASP CSP Cheat Sheet and inspired by https://github.com/google/strict-csp. The approach of having build tooling auto-generate a hash-based CSP addresses the main concern around hash-based CSPs that generating and updating the hashes manually is difficult and error-prone.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is currently no logic to process the
index.htmlto auto-generate hash-based CSPs.What is the new behavior?
Adding logic to process the
index.htmlto auto-generate hash-based CSPs.Does this PR introduce a breaking change?
Other information