Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update all non-major dependencies #28648

Merged
merged 3 commits into from
Oct 17, 2024
Merged

build: update all non-major dependencies #28648

merged 3 commits into from
Oct 17, 2024

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Oct 16, 2024

Takeover of #28644 which also bumps the Bazel version which is needed for the @aspect_bazel_lib version increase.

angular-robot and others added 2 commits October 16, 2024 19:14
@angular-robot
build: update all non-major dependencies
83a47d2 
Closes angular#28644 as a pr takeover
@dgp1130
build: bump Bazel version to 5.4.1
b1a9abd 
This is needed for `ctx.actions.run_shell(toolchain = ...)` which was added in 5.4.0 and needed for `@aspect_bazel_lib` v2.9.2.
@dgp1130 dgp1130 marked this pull request as ready for review October 16, 2024 22:41
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 16, 2024
@dgp1130 dgp1130 added the target: minor This PR is targeted for the next minor release label Oct 16, 2024
@dgp1130
build: add tslib dependency to @angular/ssr target
a8267d9 
Not sure why this wasn't needed before, but it seems to be necessary with the version bumps.
@angular-robot angular-robot bot requested a review from jkrems October 16, 2024 23:08
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Oct 17, 2024

@alan-agius4, there was a test failure that tslib was not included in deps of @angular/ssr. I'm not clear why this suddenly became an issue for this upgrade, but adding it to deps seems to fix the problem. Can you confirm that it's ok for tslib to be in included in the output? Otherwise the fix is likely to figure out why it suddenly got included when it wasn't before.

@alan-agius4
Copy link
Collaborator

@dgp1130, that is totally fine.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2024
@alan-agius4 alan-agius4 removed the request for review from jkrems October 17, 2024 07:03
@alan-agius4 alan-agius4 merged commit 1ac8b41 into angular:main Oct 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems jkrems approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgp1130 @alan-agius4 @jkrems @angular-robot