Feat new landing #6144

sumitarora · 2017-05-01T19:43:05Z

Brocco

A few coments

Brocco · 2017-05-01T19:49:11Z

packages/@angular/cli/blueprints/ng/files/e2e/app.e2e-spec.ts

@@ -9,6 +9,6 @@ describe('<%= htmlComponentName %> App', () => {

  it('should display message saying app works', () => {
    page.navigateTo();
-    expect(page.getParagraphText()).toEqual('<%= prefix %> works!');
+    expect(page.getParagraphText()).toEqual('Welcome to <%= prefix %> works!!!');


You'll need to remove works

Brocco · 2017-05-01T19:49:46Z

packages/@angular/cli/blueprints/ng/files/__path__/app/app.component.html

+  </h1>
+  <img src="https://angular.io/resources/images/logos/angular/angular.png" />
+</div>
+<h2>Here are some links to help you start: </h2>


If you're calling them links in text, please make them links with URLs.

damnn forgot those 😭

hansl · 2017-05-01T22:58:36Z

packages/@angular/cli/blueprints/ng/files/__path__/app/app.component.html

+  <h1>
+    Welcome to {{title}}!!
+  </h1>
+  <img src="https://angular.io/resources/images/logos/angular/angular.png" />


I was wondering if this could/should be an SVG inlined? So it doesn't depend on an internet connection (or CORS) :)

https://angular.io/resources/images/logos/angular/angular.svg

ok sure or I can add it to assets

I agree with @hansl please just add it in-line, this way when it is removed, it's completely gone, rather than having to change it here in markup as well as removing the file from the assets dir.

@hansl @Brocco done

ishitatsuyuki · 2017-05-02T10:11:35Z

packages/@angular/cli/blueprints/ng/files/__path__/index.html

@@ -9,6 +9,6 @@
  <link rel="icon" type="image/x-icon" href="favicon.ico">
 </head>
 <body>
-  <<%= prefix %>-root>Loading...</<%= prefix %>-root>
+  <<%= prefix %>-root></<%= prefix %>-root>


What's the point of removing the helpful message?

It conveys a message that it will take a while for Angular to load which is just not true so the decision was made to remove it by default... if you'd like to add it in you certainly can.

hansl · 2017-05-03T23:11:44Z

packages/@angular/cli/blueprints/ng/files/__path__/app/app.component.html

+  <h1>
+    Welcome to {{title}}!!
+  </h1>
+  <img width="300" src="https://angular.io/resources/images/logos/angular/angular.svg" />


Could you inline the image? It's SVG so you can just copy its content in the HTML, and that way even without a network connection you get it.

I agree, please embed the SVG or inline a base64 encoded image for easier removal.

hansl · 2017-05-03T23:11:57Z

packages/@angular/cli/blueprints/ng/files/__path__/app/app.component.html

-<h1>
-  {{title}}
-</h1><% if (routing) { %>
+<div style="text-align:center">


Add a comment at the top that this whole content can be removed.

hansl · 2017-05-04T00:32:50Z

Please rebase on top of master.

googlebot · 2017-05-04T01:11:04Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

hansl · 2017-05-04T17:16:48Z

CLA should be ignored. I verified it's good.

hansl · 2017-05-04T17:17:12Z

(the CLA status will never resolve, I'm going to merge this once all reviewers are okay)

googlebot · 2017-05-05T14:04:34Z

CLAs look good, thanks!

Brocco

Nice work, thanks for making the changes... please resolve the external Angular logo image issue that @hansl commented about.

dave11mj · 2017-05-09T14:49:24Z

packages/@angular/cli/blueprints/ng/files/package.json

@@ -12,11 +12,13 @@
  },
  "private": true,
  "dependencies": {
+    "@angular/animations": "^4.0.0",


Could we add this dependency on #5786 ? Or update this PR to integrate BrowserAnimationsModule? simply adding the dependency to the package wouldn't make it any easier to use animations or angular material as requested on #5928. It would also take up space from apps that do not need animations.

Also, does not fix #5785 which was closed in favor of #5928

@dave11mj About #5786; importing Animations into the NgModule has a lot of impact on the rendering and it can negatively affect performance if you're not using animations. As such we just add it to the package.json to facilitate you importing it, if you need to, but we don't force you to remove it if you don't. It will not be included in the build if you don't need it.

I understand that, which is why a flag makes sense for it. Where I am confused is what benefit does it provide to include on the package.json which would download it to offline caches and such for projects that may not use animations at all.

Also if its preferred to always have @angular/animations whether is needed or not for #5928 then we could at least re-open #5785 to tackle optionally importing browser animations.

Fix angular#5928 Fix angular#6125

angular-automatic-lock-bot · 2019-09-12T00:42:21Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

sumitarora requested review from hansl and Brocco May 1, 2017 19:43

googlebot added the cla: yes label May 1, 2017

Brocco suggested changes May 1, 2017

View reviewed changes

sumitarora added the state: WIP label May 1, 2017

sumitarora force-pushed the feat-new-landing branch from 6bd0b7e to 97be4f5 Compare May 1, 2017 20:11

sumitarora removed the state: WIP label May 1, 2017

hansl reviewed May 1, 2017

View reviewed changes

sumitarora force-pushed the feat-new-landing branch 2 times, most recently from 858c776 to 1c86f97 Compare May 2, 2017 00:28

ishitatsuyuki reviewed May 2, 2017

View reviewed changes

sumitarora force-pushed the feat-new-landing branch 3 times, most recently from 836e95b to 6246a99 Compare May 2, 2017 18:24

hansl suggested changes May 3, 2017

View reviewed changes

hansl changed the base branch from 1.1.x to master May 4, 2017 00:32

sumitarora force-pushed the feat-new-landing branch from 6246a99 to 9e4365b Compare May 4, 2017 01:11

googlebot added cla: no and removed cla: yes labels May 4, 2017

sumitarora closed this May 4, 2017

sumitarora reopened this May 4, 2017

sumitarora force-pushed the feat-new-landing branch from 9e4365b to 16dad7c Compare May 4, 2017 13:45

sumitarora closed this May 4, 2017

sumitarora reopened this May 4, 2017

hansl added cla: yes and removed cla: no labels May 4, 2017

This was referenced May 5, 2017

feat(@angular/cli): adds --animation flag to ng new #5786

Closed

Add dependency on @angular/animations for ng new projects #5928

Closed

sumitarora force-pushed the feat-new-landing branch from 16dad7c to 5d18b21 Compare May 5, 2017 14:04

sumitarora force-pushed the feat-new-landing branch from 5d18b21 to 0b66e4b Compare May 5, 2017 14:30

sumitarora added 4 commits May 5, 2017 12:03

feat(@angular/cli): adding language service and animations

cffd8ed

feat(@angular/cli): removed loading from index.html

85ad323

feat(@angular/cli): removed Forms and Http Module from app.module.ts

2b95dba

feat(@angular/cli): updating landing page

6ae3068

sumitarora force-pushed the feat-new-landing branch 2 times, most recently from 173d84b to d662833 Compare May 5, 2017 16:09

Brocco previously approved these changes May 8, 2017

View reviewed changes

test: fixing tests for landing page changes

4d4a4d7

sumitarora dismissed Brocco’s stale review via 4d4a4d7 May 8, 2017 14:13

sumitarora force-pushed the feat-new-landing branch from d662833 to 4d4a4d7 Compare May 8, 2017 14:13

dave11mj reviewed May 9, 2017

View reviewed changes

hansl approved these changes May 9, 2017

View reviewed changes

filipesilva merged commit 0ac878a into angular:master May 9, 2017

This was referenced May 9, 2017

Please add tslint-language-service to dependencies #6125

Closed

feat(@angular/cli): adds --animation flag to ng new #6244

Closed

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018

feat(@angular/cli): new project landing page (angular#6144)

31bdeab

Fix angular#5928 Fix angular#6125

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat new landing #6144

Feat new landing #6144

sumitarora commented May 1, 2017 •

edited by filipesilva

Loading

Brocco left a comment

Brocco May 1, 2017

Brocco May 1, 2017

sumitarora May 1, 2017

hansl May 1, 2017

sumitarora May 1, 2017

Brocco May 2, 2017

sumitarora May 2, 2017

ishitatsuyuki May 2, 2017

Brocco May 8, 2017

hansl May 3, 2017

Brocco May 8, 2017

hansl May 3, 2017

sumitarora May 5, 2017

hansl commented May 4, 2017

googlebot commented May 4, 2017

hansl commented May 4, 2017

hansl commented May 4, 2017

googlebot commented May 5, 2017

Brocco left a comment

dave11mj May 9, 2017 •

edited

Loading

hansl May 9, 2017

dave11mj May 9, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

Feat new landing #6144

Feat new landing #6144

Conversation

sumitarora commented May 1, 2017 • edited by filipesilva Loading

Brocco left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansl commented May 4, 2017

googlebot commented May 4, 2017

hansl commented May 4, 2017

hansl commented May 4, 2017

googlebot commented May 5, 2017

Brocco left a comment

Choose a reason for hiding this comment

dave11mj May 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 12, 2019

sumitarora commented May 1, 2017 •

edited by filipesilva

Loading

dave11mj May 9, 2017 •

edited

Loading