-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(@angular-cli): update README as per #6070 #6491
Conversation
The 0.0.0.0 host format will never work with current webpack version and will always show "invalid host header". Instead, a valid domain or public IP has to be specified. See angular#6070 .
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@dimitrovs Please, could you fix commit message.
|
@PavelGonzales sorry, I don't think I can amend the commit message as I did this change directly in GitHub. But it's a simple one line change in the README, may be you guys can just redo it in your repo. |
Is there any options to support 0.0.0.0 hostname? |
@dimitrovs you can amend the commit message by locally cloning the fork, amending the commit, and force-pushing to the fork. this will automatically update the commit in the pull request. good luck! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes please.
``` | ||
You have to use exactly the same `<public ip>` or `<domain` when opening the app or you will get "Invalid Host header". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note here about using the --public-host
? Something like
If you need to use `0.0.0.0` to expose your server to the local network, you'll need to pass the `--public-host` option to indicate the URL that it will be accessed as.
``` | ||
You have to use exactly the same `<public ip>` or `<domain` when opening the app or you will get "Invalid Host header". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<domain
is missing closing >
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, thanks for the contribution! There's the issue with your commit message that @gioragutt explained, but can you also make the small changes I requested?
These options are going to be refactored in v6. |
@hansl is there any place to read about upcoming changes? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The 0.0.0.0 host format will never work with current webpack version and will always show "invalid host header". Instead, a valid domain or public IP has to be specified. See #6070 .