Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(@angular-cli): update README as per #6070 #6491

Closed
wants to merge 1 commit into from

Conversation

dimitrovs
Copy link

The 0.0.0.0 host format will never work with current webpack version and will always show "invalid host header". Instead, a valid domain or public IP has to be specified. See #6070 .

The 0.0.0.0 host format will never work with current webpack version and will always show "invalid host header". Instead, a valid domain or public IP has to be specified. See angular#6070 .
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dimitrovs
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@PavelGonzales
Copy link

@dimitrovs Please, could you fix commit message.

Please fix the failing commit messages before continuing...
Commit message guidelines: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit

@dimitrovs dimitrovs changed the title Update README as per #6070 docs(@angular-cli): update README as per #6070 May 31, 2017
@dimitrovs
Copy link
Author

@PavelGonzales sorry, I don't think I can amend the commit message as I did this change directly in GitHub. But it's a simple one line change in the README, may be you guys can just redo it in your repo.

@glebmachine
Copy link

Is there any options to support 0.0.0.0 hostname?

@gioragutt
Copy link
Contributor

@dimitrovs you can amend the commit message by locally cloning the fork, amending the commit, and force-pushing to the fork. this will automatically update the commit in the pull request. good luck!

@filipesilva filipesilva self-assigned this Jun 1, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes please.

```
You have to use exactly the same `<public ip>` or `<domain` when opening the app or you will get "Invalid Host header".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note here about using the --public-host? Something like

If you need to use `0.0.0.0` to expose your server to the local network, you'll need to pass the `--public-host` option to indicate the URL that it will be accessed as.

```
You have to use exactly the same `<public ip>` or `<domain` when opening the app or you will get "Invalid Host header".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<domain is missing closing >.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks for the contribution! There's the issue with your commit message that @gioragutt explained, but can you also make the small changes I requested?

@hansl
Copy link
Contributor

hansl commented Feb 8, 2018

These options are going to be refactored in v6.

@hansl hansl closed this Feb 8, 2018
@gioragutt
Copy link
Contributor

@hansl is there any place to read about upcoming changes?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants