Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix broken sourcemaps #839

Merged
merged 1 commit into from
May 19, 2016
Merged

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented May 19, 2016

The latest version of SystemJS fixed their support for sourcemaps, which caused our production builds to fail since our source maps weren't being generated/copied properly down the build pipeline.

This PR fixes that. Also closes #829.

@@ -7,11 +7,11 @@ module.exports = function(defaults) {
vendorNpmFiles: [
'systemjs/dist/system-polyfills.js',
'systemjs/dist/system.src.js',
'zone.js/dist/*.js',
'zone.js/dist/**/*.*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why copy all files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it would be better because of the sourcemaps. Maybe copying js and js.map might be enough though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@filipesilva
Copy link
Contributor Author

@hansl can you review again please?

@hansl
Copy link
Contributor

hansl commented May 19, 2016

Okay that makes more sense :) LGTM.

@hansl hansl merged commit 234de2b into angular:master May 19, 2016
@zackarychapple
Copy link
Contributor

Can a release get cut with this change so people not running on master can get it?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build -prod copying over files that are already bundled
3 participants