This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
docs(tutorial): french translation(pt6) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,32 +11,56 @@ block includes | |||
| :marked | |||
| # Getting and Saving Data with HTTP | |||
|
|
|||
| # Récupérons et sauvons les données avec HTTP | |||
There was a problem hiding this comment.
Récupérons et sauvegardons les données avec HTTP
| Nos sponsors apprécient nos progrès. | ||
| Maintenant ils souhaitent que nous récupérions les données d'un serveur, que l'utilisateur ajoute, modifie ou supprime les héros | ||
| et sauvegarde ces changements sur le serveur. | ||
|
|
There was a problem hiding this comment.
Cette formulation me paraît lourde (à la lecture du moins).
Qu'est-ce que tu penses de :
Maintenant, ils souhaitent que nous récupérions les données depuis un serveur, permettre aux utilisateurs d'ajouter, modifier et supprimer des héros et sauvegarder ces changements sur le serveur.
| We start by creating `HeroSearchService` that sends search queries to our server's web api. | ||
|
|
||
| Nous commençons par créer un `HeroSearchService` qui envoie les recherches à l'API web de notre serveur |
There was a problem hiding this comment.
Il manque le point en fin de phrase.
cbalit
force-pushed
the
tr-cbalit-39
branch
from
f5d3df5 to
b9ef7ff
Compare
|
J'ai intégré toutes les remarques de @RudyWeber (super review merci) |
|
@cbalit il reste une remarque ouverte... |
|
@manekinekko je pense que c'est bon c'est lié au commentaire précédent. Tu peux merge :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this PR...
Please check if the PR fulfills these requirements
Please provide the issue number?
issue #39
Did you finish translating the whole issue?
What kind of change does this PR introduce? (check one with "x")
Other information: