fix(browser): prevent ie from getting into redirect loop

Closes #1075 Closes #1079 Closes #1085
angular · Jun 22, 2012 · ffb2701 · ffb2701
1 parent 0d57f13
commit ffb2701
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/ng/browser.js b/src/ng/browser.js
@@ -149,6 +149,7 @@ function Browser(window, document, $log, $sniffer) {
   self.url = function(url, replace) {
     // setter
     if (url) {
+      if (lastBrowserUrl == url) return;
       lastBrowserUrl = url;
       if ($sniffer.history) {
         if (replace) history.replaceState(null, '', url);

diff --git a/test/ng/browserSpecs.js b/test/ng/browserSpecs.js
@@ -468,6 +468,14 @@ describe('browser', function() {
       fakeWindow.location.href = "http://ff-bug/?single%27quote";
       expect(browser.url()).toBe("http://ff-bug/?single'quote");
     });
+
+    it('should not set URL when the URL is already set', function() {
+      var current = fakeWindow.location.href;
+      sniffer.history = false;
+      fakeWindow.location.href = 'dontchange';
+      browser.url(current);
+      expect(fakeWindow.location.href).toBe('dontchange');
+    });
   });
 
   describe('urlChange', function() {