Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

angular.merge() turns regexps into empty objects #12409

Closed
mondalaci opened this issue Jul 22, 2015 · 0 comments
Closed

angular.merge() turns regexps into empty objects #12409

mondalaci opened this issue Jul 22, 2015 · 0 comments
Labels
component: misc core severity: broken expected use type: bug
Milestone
Backlog - won't fix

Comments

@mondalaci
Copy link 

var jQueryMerged = $.extend(true, {}, {regexp:/blah/});
var angularMerged = angular.merge({}, {regexp:/blah/});

jQueryMerged.regexp yields /blah/
angularMerged.regexp yields Object {}
@mondalaci mondalaci mentioned this issue Jul 22, 2015
Closed
@sreeramu sreeramu mentioned this issue Jul 23, 2015
Closed
@Narretz Narretz added this to the Backlog milestone Jul 23, 2015
@caitp caitp closed this as completed in a5221f3 Jul 24, 2015
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@sreeramu @netman92
fix(merge): regExp should not be treated as a objects when merging.
83283ae 
angular.merge({ key: /regexp/ }) now works the way you'd expect it to.

Horray!

Closes angular#12419
Closes angular#12409
@NickBolles NickBolles mentioned this issue Aug 21, 2015
Closed
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@sreeramu @caitp
fix(merge): regExp should not be treated as a objects when merging.
4219233 
angular.merge({ key: /regexp/ }) now works the way you'd expect it to.

Horray!

Closes angular#12419
Closes angular#12409
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core severity: broken expected use type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

No branches or pull requests
2 participants
@mondalaci @Narretz