Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

[ngAria] aria-required is not allowed for input type="checkbox" #13078

Closed
k7sleeper opened this issue Oct 13, 2015 · 5 comments
Closed

[ngAria] aria-required is not allowed for input type="checkbox" #13078

k7sleeper opened this issue Oct 13, 2015 · 5 comments
Labels
component: ngAria type: bug
Milestone
1.4.x

Comments

@k7sleeper
Copy link

We've the problem that ngAria adds attribute aria-required to our checkboxes and W3C Validator rightly complains about that.

What am I doing wrong? Or is it an issue in ngAria?
@gkalpak
Copy link
Member

gkalpak commented Oct 13, 2015 •
edited
Loading

Could you provide a demo of the issue (preferrably a live reproduction using CodePen, Plnkr etc) ?

@Narretz Narretz added this to the Purgatory milestone Oct 15, 2015
@Narretz
Copy link
Contributor

Narretz commented Oct 15, 2015

I think this is going to be fixed by #13095

@gkalpak
Copy link
Member

gkalpak commented Oct 16, 2015

@Narretz, I thought #13095 is about tabindex (this one is about aria-required). No ?

@marcysutton
Copy link
Contributor

We need another PR to cover extraneous aria-* attributes....it piggybacks on the tabindex work, but should remain separate. I'll get on it! :)

@Narretz
Copy link
Contributor

Narretz commented Oct 27, 2015

Yeah, it's a different issue, sorry for the noise. Thanks @marcysutton for all the work!

@Narretz Narretz modified the milestones: 1.4.x, Purgatory Oct 27, 2015
marcysutton added a commit to marcysutton/angular.js that referenced this issue Dec 9, 2015
@marcysutton
fix(ngAria): Apply ARIA attrs correctly
709b79c 
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
@marcysutton marcysutton mentioned this issue Dec 9, 2015
Closed
marcysutton added a commit to marcysutton/angular.js that referenced this issue Jan 18, 2016
@marcysutton
fix(ngAria): Apply ARIA attrs correctly
82c6438 
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 2, 2016
@marcysutton
fix(ngAria): Apply ARIA attrs correctly
de718c8 
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 3, 2016
@marcysutton
fix(ngAria): Apply ARIA attrs correctly
9af2245 
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 3, 2016
@marcysutton
fix(ngAria): Apply ARIA attrs correctly
86e49e1 
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
@gkalpak gkalpak closed this as completed in d06431e Feb 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ngAria type: bug
Projects
None yet
Milestone
1.4.x
Development

No branches or pull requests
4 participants
@marcysutton @Narretz @k7sleeper @gkalpak