ngMock contains unannotated functions

[bisubus]

ngMock contains unannotated functions, i.e.

angular.js/src/ngMock/angular-mocks.js

Line 2527 in d67e999

fn = function($provide) {

angular.js/src/ngMock/angular-mocks.js

Line 2652 in d67e999

modules.unshift(function($injector) {

This prevents angular-mocks.js from being minified.

The problem was conditional (angular.mock.module({ mockedService: ... }) syntax was incompatible with minification before this commit), now it throws

[$injector:modulerr] Failed to instantiate module function (e){l.$providerInjector=e} due to:
Error: [$injector:unpr] Unknown provider: e
http://errors.angularjs.org/1.5.0-beta.2/$injector/unpr?p0=e

unconditionally.

[Narretz]

Probably happens because ngMock isn't usually minified, because it should only run in tests, where minification isn't really needed. But we should probably fix it anyway.

[gkalpak]

Indeed I don't think it is intended to be minified. (In fact we are not producing a angular-mocks.min.js as part of our build.)
Why minify it ?

[szimek]

@gkalpak I just modified our Gulp file to prevent minification of angular-mocks.js as a workaround for this issue. Previously, we just added angular-mocks.js to a list of all external JS files (but only if ENV === "test") that later all ended up as a single vendor.js file, which is loaded in index.html. It was just much easier to load it like this, especially for e2e tests.

[gkalpak]

OK, from a quick search, this has been brought up #3534 and #4448 before.

The last comment from @IgorMinar sums it up nicely, I think:

[...] We have no way to test it right now, so if we break it in the future, we'll fix it when someone complains.

So, @szimek, did you just complain ? 😄

[szimek]

@gkalpak I just wanted to explain why people minify it 😄 I found a workaround for it, so it's fine for me as it is, but I suspect there are a lot more people who just add angular-mocks.js to their standard pipeline that minifies everything and will complain later on 😄

[bisubus]

@gkalpak It is rare scenario but it exists, I've experienced problems after 1.5.0-beta.2. I test here that class detection will fail in transpiled and minified code on some condition, while it will pass on another condition. Without mgMock being fixed, I have to revise the way the specs are being bundled.

[gkalpak]

@bisubus, @szimek, could you try out this angular-mocks.js and see if it works for you ?

[messo]

@gkalpak, we had the same issue as OP, and I have just tried your build and it is working for us 👍 Thanks! It would be nice to see this in 1.5.1

[gkalpak]

Thx, @messo, for the feedback. If it doesn't make it into v1.5.1 it will sure make it into v1.5.2 (but let's think positive 😛 )