Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): strip off empty hash segments when comparing #10747

Closed
wants to merge 0 commits into from

Conversation

tleruitte
Copy link
Contributor

Backported from e93710f

The url is the same whether or not there is an empty # marker at the end.
This prevents unwanted calls to update the browser, since the browser is
automatically applying an empty hash if necessary to prevent page reloads.

Closes #9635

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@tleruitte
Copy link
Contributor Author

Closed in favour of #10748 . Sorry for the disagreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants