This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMock): Add responseType function parameter in mock httpbackend for passthrough #11524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
passthrough The ngMock $httpBackend allows http request routes that have not been defined for mocking to be passed through to the real http backend service. The responseType parameter was missing in the ngMock httpbackend parameter list. closes angular#5415
prateek14
force-pushed
the
mockhttpbackend-responseType-fix
branch
from
ac15073 to
aeaff8e
Compare
|
+1 |
|
This is not what ngMock $httpBackend was designed for - it is supposed to be for unit tests that should never touch a slow external service. Perhaps you wanted to use ngE2EMock instead? |
|
When I use ngMockE2E and specify to passThrough() a request for some binary file (lets say, a jpeg image) and then request it somewhere in my code with $http responseType: 'blob' the response.data property is always a string, not a blob. When I use it without ngMockE2E it works as expected. It seems like ngMockE2E is swallowing the responseType when passing through a request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ngMock $httpBackend allows http request routes that have not been defined
for mocking to be passed through to the real http backend service. The
responseType parameter was missing in the ngMock httpbackend parameter
list.
closes #5415