This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
refactor(form): remove the use of the private setter function #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the private `setter` function from $parse Replace the use of `setter` from the `form` directive to use $parse
|
|
||
| function getSetter(expression) { | ||
| if (expression === '') { | ||
| return $parse('this[""]').assign; |
There was a problem hiding this comment.
410f7c6 added some code changes and a test so when the name is the empty string, then the form object is stored in the scope under the '' name. This code workarounds this case as the empty expression is not assignable
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Remove the private `setter` function from $parse Replace the `setter` from the `form` directive with $parse Closes angular#12483
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
Remove the private `setter` function from $parse Replace the `setter` from the `form` directive with $parse Closes angular#12483
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the private
setterfunction from $parseReplace the use of
setterfrom theformdirective to use $parse