This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
docs(CONTRIBUTING): fix some minor typos #12497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,7 +215,7 @@ Must be one of the following: | |||
| * **docs**: Documentation only changes | |||
| * **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing | |||
| semi-colons, etc) | |||
| * **refactor**: A code change that neither fixes a bug or adds a feature | |||
| * **refactor**: A code change that neither fixes a bug nor adds a feature | |||
There was a problem hiding this comment.
I'm not sure the "nor" is necessarily more helpful than "or" for non-native English speakers
There was a problem hiding this comment.
Because https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type
I just copied it.
There was a problem hiding this comment.
It's just my opinion, keeping the language simpler makes it more accessible to non-english speakers. But, in this particular case it might not matter that much, so LGTM anyways --- we can fix it later if it confuses people.
|
The rest looks alright with me |
|
Thanks @caitp :) |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Summary: - Use properly capitalized GitHub brand name - Correctly negate two clauses using "nor" (caitp feels this may confuse non-english speakers and need to be revised, but hopefully not) - Correctly end sentence with period Closes angular#12497
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
Summary: - Use properly capitalized GitHub brand name - Correctly negate two clauses using "nor" (caitp feels this may confuse non-english speakers and need to be revised, but hopefully not) - Correctly end sentence with period Closes angular#12497
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.