Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Issue with canceling XHR request using promises - fixed #12525

Closed
wants to merge 0 commits into from

Conversation

netman92
Copy link
Contributor

@netman92 netman92 commented Aug 8, 2015

Fixes #10890 and #9332.

@jtheoof
Copy link

jtheoof commented Aug 21, 2015

@netman92 Your master branch is way behind angular/master.

You should do the following:

git remote add angular git@github.com:angular/angular.js.git
git fetch --all
git reset --hard angular/master
git checkout -b allow-promise-cancelling
git cherry-pick fd5baead857c514d1f2e8bb88ee0f5e0031acd9b # getting your commit back (possible conflicts)
git push origin # your remote

And submit a new merge request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants