Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngOptionsDirective): fix form pristine (use !equals function instead of !== for issue 13211) #13326

Closed
wants to merge 2 commits into from
Closed

fix(ngOptionsDirective): fix form pristine (use !equals function instead of !== for issue 13211) #13326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da0e0c
fix(ngOptionsDirective): fix form pristine (use !equals function inst…
m-amr Nov 18, 2015
4613a73
fix(ngOptionsDirective): use equals function if attr.multiple(to save…
m-amr Nov 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ng/directive/ngOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,8 @@ var ngOptionsDirective = ['$compile', '$parse', function($compile, $parse) {
// Check to see if the value has changed due to the update to the options
if (!ngModelCtrl.$isEmpty(previousValue)) {
var nextValue = selectCtrl.readValue();
if (ngOptions.trackBy ? !equals(previousValue, nextValue) : previousValue !== nextValue) {
var isNotPrimitive = ngOptions.trackBy || multiple;
if (isNotPrimitive ? !equals(previousValue, nextValue) : previousValue !== nextValue) {
ngModelCtrl.$setViewValue(nextValue);
ngModelCtrl.$render();
}
Expand Down