Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template #16377

Merged
merged 1 commit into from
Dec 19, 2017
Merged

docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template #16377

merged 1 commit into from
Dec 19, 2017

Conversation

frederikprijck
Copy link
Contributor

fix broken links in PR template

@frederikprijck
Copy link
Contributor Author

I'm not sure if hardcoding blob/master is a good idea. But I prefer a working link instead of a broken. 😬

@gkalpak
Copy link
Member

gkalpak commented Dec 19, 2017

Can you change the commit message to docs(PULL_REQUEST_TEMPLATE.md): ...?

@frederikprijck
Copy link
Contributor Author

@gkalpak Updated! :)

@@ -16,8 +16,8 @@


**Please check if the PR fulfills these requirements**
- [ ] The commit message follows our [guidelines](../DEVELOPERS.md#commits)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this and the other link below to be relative? ../blob/master/DEVELOPERS.md#commits This way, they work the same in forks.

Copy link
Contributor Author

@frederikprijck frederikprijck Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm this doesn't seem to work in every situation, using an absolute url does.

I did the following:

  • Edit the template file using github UI
  • Update the URL to reflect ur changes
  • Preview the file
  • Click the link to test if it works and see it won't work coz it tries to navigate to https://github.com/frederikprijck/angular.js/blob/patch-2/blob/master/DEVELOPERS.md#commits

@Narretz Am I missing something? And what's the benefit of using a relative link to a hardcoded branch over an absolute one to the same branch?

Tbh I'd would love to have a solution which points to the file in the correct branch. However, I'm not sure that's worth the effort as there's other hardcoded absolute urls in the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay the relative format only works well if you are in the repository view / file tree. It doesn't work as part of the PR template. Just leave it absolute.

Copy link
Contributor Author

@frederikprijck frederikprijck Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use /Developers.md!

Edit: Nvm, doesn't seem to behave the same in all situations.

@gkalpak gkalpak changed the title fix(*): fix broken links in PR template docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants