-
Notifications
You must be signed in to change notification settings - Fork 27.5k
docs(PULL_REQUEST_TEMPLATE.md): fix broken links in PR template #16377
Conversation
I'm not sure if hardcoding |
Can you change the commit message to |
@gkalpak Updated! :) |
@@ -16,8 +16,8 @@ | |||
|
|||
|
|||
**Please check if the PR fulfills these requirements** | |||
- [ ] The commit message follows our [guidelines](../DEVELOPERS.md#commits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change this and the other link below to be relative? ../blob/master/DEVELOPERS.md#commits
This way, they work the same in forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm this doesn't seem to work in every situation, using an absolute url does.
I did the following:
- Edit the template file using github UI
- Update the URL to reflect ur changes
- Preview the file
- Click the link to test if it works and see it won't work coz it tries to navigate to
https://github.com/frederikprijck/angular.js/blob/patch-2/blob/master/DEVELOPERS.md#commits
@Narretz Am I missing something? And what's the benefit of using a relative link to a hardcoded branch over an absolute one to the same branch?
Tbh I'd would love to have a solution which points to the file in the correct branch. However, I'm not sure that's worth the effort as there's other hardcoded absolute urls in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay the relative format only works well if you are in the repository view / file tree. It doesn't work as part of the PR template. Just leave it absolute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use /Developers.md
!
Edit: Nvm, doesn't seem to behave the same in all situations.
fix broken links in PR template