This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): forgive unregistration of a non-registered handler #3465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped into a subtle bug when unregisering handlers with jqLite. If you try to unregister a non-existing handler by specifing both its type and a function jqLite's
off
will fail if there was already a different handler was registered. See the test for more details.With jQuery this situation is handled correctly, that it, unregistration has no effect.
I was hesitating a bit between fixing it in jqLite or fixing directly the
indexOf
/arrayRemove
(in Angular.js). In any case the test illustrates my real problem, can amend the fix if needed.