This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(jqLite): implement the detach method
#5461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
any chance this will be merged? |
| if (parent) parent.removeChild(element); | ||
| remove: jqLiteRemove, | ||
|
|
||
| detach: function(element) { |
There was a problem hiding this comment.
don't you want to support the keepData parameter here?
There was a problem hiding this comment.
This parameter is internal. jQuery accepts an optional selector argument so jqLite shouldn't use it for sth else.
This is OK for me.
|
LGTM. |
|
@mzgol do we need this to help with the jQuery 2 support? Please reply quickly otherwise this will be pushed back |
We don't need it for anything jQuery-related. It's just a common method to move elements in the DOM without destroying their data so if Angular UI needs it, I'd merge it. The patch is small. |
|
Landed, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We at Angular UI are missing jQuery's detach:
angular-ui/bootstrap#1403 (comment)
https://github.com/angular-ui/bootstrap/pull/1391/files#diff-e8665eb306ddd26399e5b80f00dae5bbR252
Thanks.