Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FirebaseSDKAuthBackend): restore type to constructor signature #653

Closed
jeffbcross opened this issue Oct 31, 2016 · 0 comments
Closed

fix(FirebaseSDKAuthBackend): restore type to constructor signature #653

jeffbcross opened this issue Oct 31, 2016 · 0 comments
Labels
comp: auth type: chore

Comments

@jeffbcross
Copy link
Contributor

Blocked by angular/angular#12631

Angular's AoT compiler currently does not support interface type annotations inside constructor parameters. So I had to change a type from firebase.app.App to any to make ngc succeed: https://github.com/angular/angularfire2/blob/01b04a315053e7a6433e73c552754d9355b12a92/src/auth/firebase_sdk_auth_backend.ts#L30

Once the upstream issue is resolved, the type annotation should be changed back to firebase.app.App.
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Oct 31, 2016
@jeffbcross
fix(AoT): change constructor param interface type annotation to any
d7e316a 
See angular#653
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Nov 1, 2016
@jeffbcross
fix(AoT): change constructor param interface type annotation to any
390f497 
See angular#653
jeffbcross added a commit that referenced this issue Nov 1, 2016
@jeffbcross
fix(AoT): change constructor param interface type annotation to any
2c0a57f 
See #653
@davideast davideast mentioned this issue Jan 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: auth type: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffbcross @davideast