Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json files required for database and auth directories #880

Closed
cartant opened this issue Apr 1, 2017 · 0 comments
Closed

package.json files required for database and auth directories #880

cartant opened this issue Apr 1, 2017 · 0 comments

Comments

@cartant
Copy link
Contributor

cartant commented Apr 1, 2017

Version info

Angular: N/A

Firebase: N/A

AngularFire: Current master

Other (e.g. Ionic/Cordova, Node, browser, operating system): N/A

If the release candidate is to support imports like this:

import { AngularFireDatabaseModule, AngularFireDatabase } from 'angularfire2/database';
import { AngularFireAuthModule, AngularFireAuth } from 'angularfire2/auth';

package.json files will be required for the database and auth directories. Otherwise, bundlers that do not use the module entry point in the package.json will not work.

For example, the package.json file that goes into the database directory would have this content:

{ "main": "../bundles/angularfire2.umd.js" }

This is the approach that Angular takes with deep paths. For example, there is a similar package.json file in @angular/core/testing.

There is also more information in this @ngrx/effects issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant