Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added $priority function to AFUnwrappedDataSnapshot #1165

Closed
wants to merge 1 commit into from

Conversation

lyonzy
Copy link

@lyonzy lyonzy commented Sep 25, 2017

Checklist

  • Issue number for this PR: 1164
  • Docs included?: (no)
  • Test units included?: (no)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (no - doesn't seem to agree with Windows)

Description

Minor change to utils.ts and interfaces.ts to support $priority.

@davideast
Copy link
Member

Hi @lyonzy! Thank you for taking the time to send in a PR. I'd love to accept this, but in #1158 we are changing the API. In that change the AFUnwrappedSnapshot is going away. Instead we are providing more options to get the data without having to unwrap. I recommend giving it a read and see what's coming soon. I expect to merge it this week.

I unfortunately will close this PR but I do appreciate the thought and time you put into this!

@davideast davideast closed this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants