Recommend adding a reference and link to #1158 (API change proposal) #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wish I had read this prior to attempting to migrate. It may just be that now that I have stumbled through the migration changes the "Proposal" makes good sense but it seems like a resource that would help others. Much of the added goodness provided by these API changes need to be more fully explained and I think the proposal does a very good job in doing that, plus the comments section make a very good addition. I especially appreciated David's opening remark "Breaking changes are not taken lightly. If we're going to change something, we're going to make it worth your while. Trust me, these new features are well worth it." However with only the above migration doc to follow, I was cursing some unnamed person or persons long and hard over the past several days. I consider myself a skilled novice in all this RxJS-NgRx, like the majority of the folks who would be attempting this migration, and my feedback is that this was far from trivial search and replace. The end result was much cleaner and I can say that you all have delivered on David's promise, but any additional documentation to assist is going to be very much appreciated.
|
Hey @TheBolmanator! I'd like to include this, but there's too many conflicts now. I'm going to close the PR but feel free to open with a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
#1158
Description
Doc change only