Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version range and add getCountFromServer() zone wrapped method #3423

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

davideast
Copy link
Member

No description provided.

@davideast davideast merged commit 5793d6f into master Sep 1, 2023
18 checks passed
@davideast davideast deleted the de-16p branch September 1, 2023 15:18
@atsjo
Copy link

atsjo commented Sep 5, 2023

The version range had no effect on the build output... I tested 16.0.0-canary.5793d6f, and it seems to still have
"firebase": "^9.8.0",
"rxfire": "^6.0.0",
as dependencies, causing error when building with firebase 10.x. I resolve this via overrides in pnpm....

@atsjo
Copy link

atsjo commented Sep 14, 2023

changing the firebase dep in https://github.com/angular/angularfire/blob/master/src/package.json to
"firebase": "^9.8.0 || ^10.0.0"
should fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants