fix(database): allow null values for equalTo, etc. #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install
,npm run build
, andnpm test
run successfully? noAfter following the steps in the contribution guide, the generated
test-root.umd.js
bundle was empty - apart from the boilerplate. This could have something to do with Windows being my OS. Hopefully, Travis will run the tests for me.Description
This PR includes a refactor to rename a method that was considered to be misleading and a fix to allow the
equalTo
,startAt
andendAt
options for list queries to benull
- as the current AngularFire2 behaviour differs from that of the underlying SDK (see the repro in the associated issue).I've renamed the method to
isNil
- rather than the suggestedisEmpty
- asisNil
is the name that's used in lodash (for an identical method) and usingisEmpty
would make the implementation ofisEmptyObject
too confusing: