fix(database): removed unused query option #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query option is ignored when using objects, so referencing the list docs is misleading.
The docs mention that lists should be used for querying/filtering and the query option is ignored by the object factory. The query option should be removed so that it is no longer suggested by TypeScript-based tools, etc. Closes angular#706
|
@cartant Thanks for cleaning this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install,npm run build, andnpm testrun successfully? noThe in-a-clean-directory thing doesn't work for me; I blame Windows. (And my Mac is packed up, as we are moving house.)
Description
This PR removes a misleading (and malformed) comment in the
FirebaseObjectObservabledocumentation that suggests thequeryoption can be used in a manner similar to that for theFirebaseListObservable. It cannot be, as the option is ignored in theFirebaseObjectObservablefactory's implementation.This PR also removes the ignored
queryoption so that TypeScript-based tools don't suggest it and so that any existing usage of the option will fail with a type error rather than behave unexpectedly.